scriptoriumadmin/GitNexus
1
0
Fork 0
mirror of https://github.com/abhigyanpatwari/GitNexus.git synced 2026-09-11 22:53:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

fix: resolve CI failures in security hardening PR

Browse source 
- Fix prettier formatting in api.ts (line length, brace style)
- Fix prettier formatting in local-backend.ts (line length)
- Update impact-batching-grouping tests: BFS traversal now uses
  executeParameterized instead of executeQuery after the injection
  fix, so test mocks must route r.type IN queries through
  executeParameterizedMock instead of executeQueryMock
This commit is contained in:
OpenClaw 2026-04-11 07:21:18 +05:30
parent e8379098fe
commit 35e419de4c
2 changed files with 76 additions and 66 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
gitnexus/src/server/api.ts
View file

@ -1013,7 +1013,10 @@ export const createServer = async (port: number, host: string = '127.0.0.1') =>
let hasInnerQuantifier = false;
for (let i = 0; i < pattern.length; i++) {
const ch = pattern[i];
if (ch === '\\') { i++; continue; } // skip escaped chars
if (ch === '\\') {
i++;
continue;
} // skip escaped chars
if (ch === '(') {
depth++;
hasInnerQuantifier = false;
@ -1057,7 +1060,9 @@ export const createServer = async (port: number, host: string = '127.0.0.1') =>
// ReDoS protection: reject patterns with nested quantifiers
if (!isSafeRegex(pattern)) {
res.status(400).json({ error: 'Pattern rejected: potential catastrophic backtracking detected' });
res
.status(400)
.json({ error: 'Pattern rejected: potential catastrophic backtracking detected' });
return;
}

133
gitnexus/test/unit/impact-batching-grouping.test.ts
View file

@ -114,6 +114,20 @@ describe('impact: batching and grouping', () => {
},
];
}
// BFS depth traversal (now uses executeParameterized after security hardening)
if (query.includes('r.type IN')) {
const res: any[] = [];
for (let i = 0; i < 250; i++) {
res.push({
id: `node-${i}`,
name: `n${i}`,
filePath: `file-${i}.js`,
relType: 'CALLS',
confidence: null,
});
}
return res;
}
// Default target resolution
return [{ id: 'sym1', name: 'Target', filePath: 'f' }];
});
@ -148,50 +162,45 @@ describe('impact: batching and grouping', () => {
executeParameterizedMock.mockImplementation(async (...args: any[]) => {
const query = typeof args[1] === 'string' ? args[1] : String(args[0] ?? '');
if (!query.includes('STEP_IN_PROCESS'))
return [{ id: 'symA', name: 'TargetA', filePath: 'f' }];
// For STEP_IN_PROCESS in this test, return grouping rows
return [
{
entryPointId: 'ep-1',
epName: 'EP1',
epType: 'Function',
epFilePath: '/p/1',
hits: 2,
minStep: 1,
},
{
entryPointId: 'ep-2',
epName: 'EP2',
epType: 'Function',
epFilePath: '/p/2',
hits: 2,
minStep: 2,
},
{
entryPointId: 'ep-1',
epName: 'EP1',
epType: 'Function',
epFilePath: '/p/1',
hits: 1,
minStep: 3,
},
{
entryPointId: 'ep-3',
epName: 'EP3',
epType: 'Function',
epFilePath: '/p/3',
hits: 1,
minStep: 1,
},
];
});
// Prepare impacted nodes: smaller set for clarity (6 nodes -> chunk size default 100 so single chunk)
executeQueryMock.mockImplementation(async (...args: any[]) => {
const query = typeof args[1] === 'string' ? args[1] : String(args[0] ?? '');
if (query.includes('r.type IN') && !query.includes('STEP_IN_PROCESS')) {
// return 6 nodes
if (query.includes('STEP_IN_PROCESS')) {
// For STEP_IN_PROCESS in this test, return grouping rows
return [
{
entryPointId: 'ep-1',
epName: 'EP1',
epType: 'Function',
epFilePath: '/p/1',
hits: 2,
minStep: 1,
},
{
entryPointId: 'ep-2',
epName: 'EP2',
epType: 'Function',
epFilePath: '/p/2',
hits: 2,
minStep: 2,
},
{
entryPointId: 'ep-1',
epName: 'EP1',
epType: 'Function',
epFilePath: '/p/1',
hits: 1,
minStep: 3,
},
{
entryPointId: 'ep-3',
epName: 'EP3',
epType: 'Function',
epFilePath: '/p/3',
hits: 1,
minStep: 1,
},
];
}
// BFS depth traversal (now uses executeParameterized after security hardening)
if (query.includes('r.type IN')) {
const res: any[] = [];
for (let i = 0; i < 6; i++)
res.push({
@ -203,8 +212,8 @@ describe('impact: batching and grouping', () => {
});
return res;
}
return [];
// Default target resolution
return [{ id: 'symA', name: 'TargetA', filePath: 'f' }];
});
const params = { target: 'TargetA', direction: 'downstream', maxDepth: 1 } as any;
@ -240,24 +249,6 @@ describe('impact: batching and grouping', () => {
(backend as any).repos.set(repoHandle.id, repoHandle);
(backend as any).ensureInitialized = vi.fn().mockResolvedValue(undefined);
// Depth traversal returns 500 impacted nodes
executeQueryMock.mockImplementation(async (...args: any[]) => {
const query = typeof args[1] === 'string' ? args[1] : String(args[0] ?? '');
if (query.includes('r.type IN') && !query.includes('STEP_IN_PROCESS')) {
const res: any[] = [];
for (let i = 0; i < 500; i++)
res.push({
id: `node-${i}`,
name: `n${i}`,
filePath: `file-${i}.js`,
relType: 'CALLS',
confidence: null,
});
return res;
}
return [];
});
const chunkSizes: number[] = [];
executeParameterizedMock.mockImplementation(async (...args: any[]) => {
@ -278,6 +269,20 @@ describe('impact: batching and grouping', () => {
];
}
// BFS depth traversal (now uses executeParameterized after security hardening)
if (query.includes('r.type IN')) {
const res: any[] = [];
for (let i = 0; i < 500; i++)
res.push({
id: `node-${i}`,
name: `n${i}`,
filePath: `file-${i}.js`,
relType: 'CALLS',
confidence: null,
});
return res;
}
if (query.includes('COUNT(DISTINCT s.id)')) {
// moduleQuery: return a module row
return [{ name: 'ModuleA', hits: 42 }];