scriptoriumadmin/GitNexus
1
0
Fork 0
mirror of https://github.com/abhigyanpatwari/GitNexus.git synced 2026-10-07 02:58:02 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

docs(test): correct a stale status note left behind by a later fix

Browse source 
The A1/A5 header still said "edge resolution REMAINING ... neither is
implemented". Both shapes resolve — the typeable receiver precisely, the
untyped one by workspace-unique name — and the tests below assert exactly that,
so the note contradicted the file it sat on.

It was accurate when written and went stale when the work continued past it.
Left as-is it would tell a reviewer that a landed feature is missing.

The TRAP note is kept: the parse worker still runs built dist under vitest, and
that is still the trap it describes.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
ReidenXerx 2026-08-06 17:28:40 +03:00
parent b8892e02dc
commit 152a0ee201
1 changed files with 6 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
gitnexus/test/integration/resolvers/javascript-object-properties.test.ts
View file

@ -15,24 +15,12 @@
* that dominates idiomatic JS. Not precisely solvable without types;
* covered by name-based fallback at reduced confidence.
*
* STATUS — definition nodes DONE, edge resolution REMAINING.
*
* Done: object-literal keys bound to a variable now mint both halves — the
* graph `Property` node (JAVASCRIPT_QUERIES) and the scope-resolution def
* (languages/javascript/query.ts). A config field is findable by name where it
* previously did not exist as a symbol at all.
*
* Remaining: the ACCESSES edges. The two receiver shapes need different
* mechanisms and neither is implemented:
* - Through the holding variable (`exitRules.exitMinAtrMult`) the receiver is
* typeable, so it must resolve precisely — the Const holding the literal
* has to be typed to the literal's scope, the way `classScopeByDefId` maps
* a class def to its scope.
* - Through an untyped param (`cfg.exitMinAtrMult`) it is not typeable in
* plain JS and needs name-based matching — sanctioned for dynamic languages
* here (`fieldFallbackOnMethodLookup` defaults on, and the Vue provider
* documents it recovering plain-object-literal cases) but it must carry
* reduced confidence so precision is not overclaimed.
* Both halves now land. Object-literal keys bound to a variable mint the graph
* `Property` node (JAVASCRIPT_QUERIES) and the scope-resolution def
* (languages/javascript/query.ts), and the ACCESSES edges resolve for both
* receiver shapes: precisely where the receiver is typeable, and by
* workspace-unique name where it is not — at reduced confidence, refusing to
* choose when two properties share a name (see the ambiguity cases below).
*
* TRAP, learned the hard way and recorded so the next reader does not repeat
* it: under vitest the PARSE WORKER runs the BUILT `dist/` code, because