From 00c2fe81be5d334ea18343b9afbc6d57d7710da6 Mon Sep 17 00:00:00 2001
From: Gergo Magyar <gergomagyar0@gmail.com>
Date: Thu, 27 Aug 2026 11:30:54 +0000
Subject: [PATCH] test(ignore-service): pin that _next prunes the directory,
 not just its files
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Every measured benefit of ignoring _next comes from never enumerating the
bundle tree, and no file list can observe that: anything under _next is
rejected whether the walk pruned the directory or descended and rejected each
file. childrenIgnored is the only observation that separates them.

The existing build-output tests all call shouldIgnorePath, the leaf predicate,
so a refactor moving _next to a shouldIgnorePath-only rule would keep them green
while silently restoring the full walk. These assertions close that.

Also pins that _next matches as a whole segment (_nextgen and my_next are still
walked), and that the `!_next/` negation recovers the directory at any depth —
the bare form is the one that works, since `!_next/**` alone never gets tested:
childrenIgnored prunes the directory before any descendant pattern is reached.

Placed in the .gitnexusignore-negation describe block, which owns mkPath and the
tmpdir fixture and is registered in scripts/cross-platform-tests.ts.

Verified by mutation: disabling only the pruning branch in childrenIgnored leaves
the build-output suite at 26/26 green and turns these assertions red.
---
 gitnexus/test/unit/ignore-service.test.ts | 32 +++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gitnexus/test/unit/ignore-service.test.ts b/gitnexus/test/unit/ignore-service.test.ts
index 4fb5536ef..60d6e8f77 100644
--- a/gitnexus/test/unit/ignore-service.test.ts
+++ b/gitnexus/test/unit/ignore-service.test.ts
@@ -334,6 +334,38 @@ describe('.gitnexusignore negation overrides hardcoded DEFAULT_IGNORE_LIST (#771
     expect(filter.childrenIgnored(mkPath('Env'))).toBe(false);
   });
 
+  // `_next` has to prune the DIRECTORY, not merely reject each file underneath.
+  // Every measured benefit of ignoring it comes from never enumerating the
+  // bundle tree, and no file list can show the difference — anything under
+  // `_next` is rejected either way. `childrenIgnored` is the only observation
+  // that distinguishes them, so a refactor that moved `_next` to a
+  // `shouldIgnorePath`-only rule would keep the build-output suite green while
+  // silently restoring the full walk.
+  it('prunes emitted _next output as a directory, at any depth', async () => {
+    const filter = await createIgnoreFilter(tmpDir);
+
+    expect(filter.childrenIgnored(mkPath('_next'))).toBe(true);
+    expect(filter.childrenIgnored(mkPath('android/app/src/main/assets/public/_next'))).toBe(true);
+  });
+
+  it('matches _next as a whole segment, so _nextgen source is still walked', async () => {
+    const filter = await createIgnoreFilter(tmpDir);
+
+    expect(filter.childrenIgnored(mkPath('src/_nextgen'))).toBe(false);
+    expect(filter.childrenIgnored(mkPath('packages/my_next'))).toBe(false);
+  });
+
+  it('`!_next/` negation unlocks the emitted output directory at any depth', async () => {
+    // The bare form is the one that works. `!_next/**` alone is a silent no-op:
+    // `childrenIgnored` prunes the directory before any descendant pattern is
+    // ever tested, so no file underneath reaches `ignored`.
+    await fs.writeFile(path.join(tmpDir, '.gitnexusignore'), '!_next/\n');
+    const filter = await createIgnoreFilter(tmpDir);
+
+    expect(filter.childrenIgnored(mkPath('_next'))).toBe(false);
+    expect(filter.childrenIgnored(mkPath('android/app/src/main/assets/public/_next'))).toBe(false);
+  });
+
   it('prunes a nested env directory only when pyvenv.cfg identifies a virtual environment', async () => {
     await fs.mkdir(path.join(tmpDir, 'backend', 'env'), { recursive: true });
     await fs.writeFile(path.join(tmpDir, 'backend', 'env', 'pyvenv.cfg'), 'home = python\n');